Stage changes to main #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output of "ps -ef" not also includes the command but also the process age and process arguments. Both can have digits in its string which may interfere when grepping for an instance number like 00 or 01. To fix this, let ps print only the executable with its path. Example: ps with default output - 2 lines match where only 1st line should match /usr/sap/A22/D01/exe/sapstartsrv pf=/usr/sap/A22/SYS/profile/A22_D01_sapa22u01 -D -u a22adm /usr/sap/A22/ASCS02/exe/sapstartsrv pf=/usr/sap/A22/SYS/profile/A22_ASCS02_sapa22u01 -D -u a22adm Example: ps with custom layout, only one line matches as expected /usr/sap/A22/D01/exe/sapstartsrv
This fixes an issue when running with strategy free: > ERROR! The 'ansible.builtin.pause' module bypasses the host loop, which > is currently not supported in the free strategy and would instead > execute for every host in the inventory list. Furthermore, the documentation for ansible.builtin.pause states: To pause/wait/sleep per host, use the ansible.builtin.wait_for module. See https://docs.ansible.com/ansible/latest/collections/ansible/builtin/pause_module.html
sap_facts.sh - ps print only executable with path
solution to issue#25
Replace ansible.builtin.pause with ansible.builtin.wait_for -- merged because all reviewers approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the SAP control tasks and fact gathering in the
sap_facts.sh,restart_sapstartsrv.yml,main.yml, andprepare.ymlfiles. The most important changes include updating commands for better process checking, replacing pauses with more appropriate wait mechanisms, and refining variable usage.Improvements to process checking and control tasks:
plugins/modules/sap_facts.sh: Modified thecheck_sapstartsrvfunction to useps -eo exefor better process checking.Enhancements to task execution and waiting mechanisms:
roles/sap_control/tasks/functions/restart_sapstartsrv.yml: Replacedansible.builtin.pausewithansible.builtin.wait_forto wait for 10 seconds forsapstartsrvinitialization.roles/sap_control/tasks/main.yml: Updated the SAP facts gathering and debugging tasks, including replacingpausewithwait_forand adjusting debug messages for clarity.Refinements to variable usage:
roles/sap_control/tasks/prepare.yml: Updated variable names and conditions for better consistency and readability.